Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUM-5757 benchmark: Collect Session Replay Record Spans #2044

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

RUM-5757 benchmark: Collect Session Replay Record Spans #2044

wants to merge 2 commits into from

Conversation

maxep
Copy link
Member

@maxep maxep commented Sep 10, 2024

What and why?

Do not merge: Tracer perfs skew the measures

Collection traces of the recording phase of Session Replay.

How?

  • Create an OpenTelemetry tracer
  • Inject the tracer in the SDK
  • Start/Stop spans of recorders.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@maxep maxep force-pushed the maxep/RUM-5757/benchmark-profiling-imp branch from 3190330 to 2f408da Compare September 10, 2024 13:12
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Sep 10, 2024 •
edited
Loading

Datadog Report

Branch report: maxep/RUM-5757/benchmark-profiling-imp
Commit report: 90d5b27
Test service: dd-sdk-ios

✅ 0 Failed, 3432 Passed, 0 Skipped, 2m 21.7s Total Time
🔻 Test Sessions change in coverage: 12 decreased, 2 increased

🔻 Code Coverage Decreases vs Default Branch (12)

This report shows up to 5 code coverage decreases.

  • test DatadogLogsTests tvOS 46.81% (-1.16%) - Details
  • test DatadogLogsTests iOS 46.76% (-1.15%) - Details
  • test DatadogCrashReportingTests tvOS 26.63% (-0.28%) - Details
  • test DatadogCrashReportingTests iOS 26.58% (-0.28%) - Details
  • test DatadogCoreTests tvOS 78.57% (-0.19%) - Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxep